Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1554: Replace AWS Access Key Pair with Task Role #1118

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

krishanthisera
Copy link
Contributor

@krishanthisera krishanthisera commented Oct 19, 2023

DO-1554: Replace AWS Access Key Pair with Task Role


Description of the proposed changes

  • Use the task role instead of the access key pair to access the s3 bucket
  • Export PrerenderTokenUrlAssociationOptions

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • N/A

@krishanthisera krishanthisera changed the title DO-1554: Replace AWS Access Key Pair DO-1554: Replace AWS Access Key Pair with Task Role Oct 19, 2023
TheOrangePuff
TheOrangePuff previously approved these changes Oct 19, 2023
Copy link
Contributor

@crispy101 crispy101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishanthisera krishanthisera merged commit 4b9ca3c into main Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants